Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve missing process variable in browser environment #299

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

noxan
Copy link
Contributor

@noxan noxan commented May 31, 2024

Follow up to close #297

  • check if process is defined, else fall back to Unknown
  • prevent the unlikely case of process.versions being defined without a node key, fall back to Unknown

@noxan noxan changed the title fix: make sure process.versions without node key also works fix: fix missing process variable in browser environment Jun 6, 2024
@noxan noxan changed the title fix: fix missing process variable in browser environment fix: Resolve missing process variable in browser environment Jun 6, 2024
@noxan
Copy link
Contributor Author

noxan commented Jun 6, 2024

@lukeocodes added a fix with this pull request

@lukeocodes
Copy link
Contributor

nice, this is a neater solution than a vite config

@lukeocodes lukeocodes merged commit 7ce44bd into deepgram:main Jun 6, 2024
1 check passed
@noxan noxan deleted the 297-process-is-undefined branch June 6, 2024 15:06
@noxan
Copy link
Contributor Author

noxan commented Jun 6, 2024

thanks for the swift response and release :)

@lukeocodes
Copy link
Contributor

no worries, thank you for your attention to detail! made it easier to test/accept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process is undefined on v3.3.1
2 participants